Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed auxiliary config paramter de440s to planet_ephemeris #1104

Merged

Conversation

Little-Ryugu
Copy link
Collaborator

Fixes #1102 .

Renamed auxiliary config paramter de440s to planet_ephemeris in sorchaConfigs and updated unit tests and docs.

Describe your changes.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Renamed auxiliary config paramter de440s to planet_ephemeris in sorchaConfigs and updated unit tests and docs.
@Little-Ryugu Little-Ryugu marked this pull request as ready for review January 17, 2025 15:01
@Little-Ryugu Little-Ryugu requested a review from mschwamb January 17, 2025 15:01
@Little-Ryugu Little-Ryugu merged commit 01b3540 into main Jan 17, 2025
7 checks passed
@Little-Ryugu Little-Ryugu deleted the Renaming-class-parameter-de440s-to-planet_ephemeris branch January 17, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch de440s and de440s_url config variable name
2 participants